Repository navigation
mintSources.py: Show "Obsolete" for out of date mirrors - #285
Merged
Merged
Conversation
show_speed_test_result() uses "if ... if ... else" instead of "if ... elif ... else", so for an out of date mirror (-1) the "Obsolete" label is set and then immediately overwritten by the else branch with "0 kB/s". The "Obsolete" label was never shown. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
show_speed_test_result()usedif download_speed == -1followed by a separateif download_speed == 0 ... else, so for an out of date mirror the "Obsolete" label was set and then immediately overwritten by theelsebranch with "0 kB/s" (and the speed column set to -1).Making the second check an
elifkeeps the "Obsolete" label.Reproduced against the installed mintsources 2.4.3 by calling the method with a mock model:
🤖 Generated with Claude Code